[Pharo-project] About SourcedMethodReference
luc.fabresse at gmail.com
Thu Nov 11 04:42:39 CET 2010
2010/11/10 Stéphane Ducasse <stephane.ducasse at inria.fr>
> On Nov 9, 2010, at 10:57 PM, Igor Stasenko wrote:
> > I think identity is better. It forcing more strict rules: no more than
> > one method reference
> > in system necessary for representing same method.
> I'm not sure I understand exactly what you mean.
> In the recent message or in the versions, you get mulitple version of the
> "same" methods but different methodreference.
That was my point. And I think that equality of SourcedMethodReference
should not be based on identity but a modified version of the
MethodReference implementation integrating the version.
> > On 9 November 2010 23:48, Luc Fabresse <luc.fabresse at gmail.com> wrote:
> >> Hi all,
> >> When SourcedMethodReference have been introduced, some tests in
> >> SystemNavigationTest turned yellow.
> >> The tests are currently expecting a MethodReference.
> >> If I modify the tests to exepect a SourcedMethodReference, the problem
> >> now on:
> >> SourcedMethodReference>>=
> >> ^self == aMethodReference.
> >> Why this has been redefined in SourcedMethodReference?
> >> I think that the super class (MethodReference) implementation is
> >> semantically better. No?
> >> MethodReference>>= anotherMethodReference
> >> "Answer whether the receiver and the argument represent the
> >> same object."
> >> ^ self species == anotherMethodReference species
> >> and: [(self classSymbol = anotherMethodReference classSymbol)
> >> and: [(self classIsMeta = anotherMethodReference classIsMeta)
> >> and: [self methodSymbol = anotherMethodReference methodSymbol]]]
> >> #Luc
> > --
> > Best regards,
> > Igor Stasenko AKA sig.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the Pharo-project