[Pharo-project] A lil simplification of MorphTreeNodeMorph

Tudor Girba tudor.girba at gmail.com
Wed Apr 6 09:30:29 CEST 2011


Hi,

60% sounds excellent!

If you are looking into MorphTreeMorph, would it be possible to look into the problem of making the submorphs fill the entire horizontal space?

Let me give you an example:
- download the Glamorous Toolkit image:
http://hudson.moosetechnology.org/job/glamorous-toolkit-latest-dev/lastSuccessfulBuild/artifact/glamoroust/*zip*/glamoroust.zip

- run GTCoder open

- select a package, select a class, expand a method and you will see that the text submorph does not scale either horizontally, or vertically

I also attached a screenshot.

Would it be possible to fix that, too? :)

Cheers,
Doru

-------------- next part --------------
A non-text attachment was scrubbed...
Name: morphtreemorph-not-filling-space.png
Type: image/png
Size: 32814 bytes
Desc: not available
URL: <http://lists.gforge.inria.fr/pipermail/pharo-project/attachments/20110406/b45806a9/attachment.png>
-------------- next part --------------

On 6 Apr 2011, at 08:57, Igor Stasenko wrote:

> On 5 April 2011 21:39, Alain Plantec <alain.plantec at yahoo.com> wrote:
>> Le 05/04/2011 20:08, Igor Stasenko a ?crit :
>>> 
>>> Cut out some code and extra morphs.
>>> It speeds up rendering to 60% of original.
>> 
>> cool
>> thanks for reviewing this code!
>>> 
>>> @Benjamin
>>> Please verify if it positioning stuff correctly. Because in my image
>>> Settings are now OK.
>>> 
>>> @all
>>> I need your feedback to know if it works correctly in other places,
>>> where tree morph used.
>> 
>> you need to remove all references to spacers inst var since it seems to be
>> not used anymore now.
>> 
>> another point, try all examples in Morphic-MorphTreeWidget-Examples.
>> now, the height of each row is constant.
> 
> Yes, so what it should be instead?
> 
>> It is because of the RowLayout that is used for MorphTreeNodeMorph instead
>> of a ProportionalLayout.
>> see ClassTreeExample before and after your changes.
>> 
>> ClassTreeExample new openOn: Object
>> 
> i will
>> cheers
>> Alain
>> 
>> 
>> 
>> 
>> 
>> 
> 
> 
> 
> -- 
> Best regards,
> Igor Stasenko AKA sig.
> 

--
www.tudorgirba.com

"Reasonable is what we are accustomed with."



More information about the Pharo-project mailing list