[Pharo-project] GitFs / MCGit
maxleske at gmail.com
Wed Apr 27 19:14:27 CEST 2011
No, it doesn't make sense at all to return nil. The reason that no exception is signalled is simply that that case should never be possible (not really an argument, I know :D). The method #packedObjectWithSignature is only sent if no loose object could be found. Then the packs are scanned and if the object isn't found in the packs the method returns nil.
I think an exception would make a lot of sense but I didn't implement an exception handling mechanism for FSGit so a user will get slapped in the face with a debugger. Better though than having to track down that nil bug...
On 27.04.2011, at 16:21, Camillo Bruni wrote:
> Hi Max,
> I took another effort to work on the git bindings of MC.
> However I ran into troubles with FSGitFilesystem on commiting.
> 1. I fail when saving the repos in GitCommit >> parents when it starts to lazily load the object which does not exist yet...
> 2. GitRespository >> packedObjectWithSignature: aGitObjectSignature
> does not throw an exception but simply returns nil? does this make sense?
> maybe you have a clue how to solve this faster than I do :-)
More information about the Pharo-project