[Pharo-project] about Sound and setting :(

Henrik Johansen henrik.s.johansen at veloxit.no
Tue Feb 1 12:36:35 CET 2011


Again, you are using the wrong version of Sound, sorry I couldn't tell you sooner.
Work has been busy :(

Remember part2 of my mail of what needed to be done?

"Update MetacelloConfiguration to use PharoSound instead of PharoNonCorePackages"

:) 

Cheers,
Henry



On Jan 30, 2011, at 6:29 58PM, Stéphane Ducasse wrote:

> Hi guys
> 
> loadSoundEnabled
> 		self loadSetting: #soundEnabled withBlock: [SoundService soundEnabled: nil].
> 
> 
> since mariano is away and I do not know what was done in Sound, I'm trying but this is not simple when you do not know
> what was the intention.
> 
> 
> The method is:  
> 
> resumePlaying: aSound quickStart: quickStart
> 	"Start playing the given sound without resetting it; it will resume playing from where it last stopped. If quickStart is true, then try to start playing the given sound immediately."
> 
> 	| doQuickStart |
> 	SoundSettings soundsEnabled ifFalse: [^ self].
> 	doQuickStart := quickStart.
> 	SoundSettings soundQuickStart ifFalse: [doQuickStart := false].
> 	PlayerProcess == nil ifTrue: [
> 		self canStartPlayer ifFalse: [^ self].
> 		^self startUpWithSound: aSound].
> 
> 	PlayerSemaphore critical: [
> 		(ActiveSounds includes: aSound)
> 			ifTrue: [doQuickStart := false]
> 			ifFalse: [
> 				doQuickStart ifFalse: [ActiveSounds add: aSound]]].
> 
> 	"quick-start the given sound, unless the sound player has just started"
> 	doQuickStart ifTrue: [self startPlayingImmediately: aSound].
> 
> 
> it refers to SoundSettings and there is no such a thing. There is no implementors of soundsEnabled
> So I tried to understand the changes made in Slice-3566 
> 
> Now the question is do we want SoundService to play the role of a setting provider?
> Originally I thought to put it in BaseSoundSystem.
> 
> But the code of henrik seems to use SoundService. Now BaseSoundSystem register itself as the default sound service.
> So I'm confused!
> 
> Help is welcome.
> 
> Stef
> 
> 
> 
> 
> 
> 
> 
> 
> 
> 





More information about the Pharo-project mailing list