[Pharo-project] Bug in FileSystem

Henrik Sperre Johansen henrik.s.johansen at veloxit.no
Sat Jan 7 14:05:28 CET 2012


On 07.01.2012 13:20, Stéphane Ducasse wrote:
> sounds like :)
>
> Stef
>
> On Jan 7, 2012, at 1:10 PM, Mariano Martinez Peck wrote:
>
>> FSReadStream>>  next: count
>>      | result |
>>      result := ByteArray new: count.
>>      handle at: position read: result startingAt: 1 count: count.
>>      position := position + 1.
>>       ^ result
>>
>>
>> shouldn't be
>>
>> FSReadStream>>  next: count
>>      | result |
>>      result := ByteArray new: count.
>>      handle at: position read: result startingAt: 1 count: count.
>>      position := position + count.
>>       ^ result
>>
>> At least with that (among some extensions) Fuel tests pass with FS :)
>>
>> Cheers
>>
>> -- 
>> Mariano
>> http://marianopeck.wordpress.com
>>
>
Still wrong though, I think...
It doesn't handle the case where you try to read past end of stream.

next: count
^self nextInto: (ByteArray new: count)

would probably be better.

Cheers,
Henry




More information about the Pharo-project mailing list